From 9c24b3089cb5866aab0ce35af1f57881a8492112 Mon Sep 17 00:00:00 2001
From: Tunglies <77394545+Tunglies@users.noreply.github.com>
Date: Thu, 13 Nov 2025 09:42:03 +0800
Subject: [PATCH] fix(editor): update editorRef initialization and handleChange
 logic for better type safety #5442

---
 src/components/profile/editor-viewer.tsx | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/src/components/profile/editor-viewer.tsx b/src/components/profile/editor-viewer.tsx
index 186815ed1..64f2e1675 100644
--- a/src/components/profile/editor-viewer.tsx
+++ b/src/components/profile/editor-viewer.tsx
@@ -103,7 +103,7 @@ export const EditorViewer = <T extends Language>(props: Props<T>) => {
     [initialData],
   );
 
-  const editorRef = useRef<monaco.editor.IStandaloneCodeEditor | null>(null);
+  const editorRef = useRef<monaco.editor.IStandaloneCodeEditor>(undefined);
   const prevData = useRef<string | undefined>("");
   const currData = useRef<string | undefined>("");
 
@@ -126,8 +126,9 @@ export const EditorViewer = <T extends Language>(props: Props<T>) => {
     });
   };
 
-  const handleChange = useLockFn(async (value: string | undefined) => {
+  const handleChange = useLockFn(async (_value?: string) => {
     try {
+      const value = editorRef.current?.getValue();
       currData.current = value;
       onChange?.(prevData.current, currData.current);
     } catch (err) {
@@ -138,6 +139,7 @@ export const EditorViewer = <T extends Language>(props: Props<T>) => {
   const handleSave = useLockFn(async () => {
     try {
       if (!readOnly) {
+        currData.current = editorRef.current?.getValue();
         onSave?.(prevData.current, currData.current);
       }
       onClose();
@@ -175,12 +177,12 @@ export const EditorViewer = <T extends Language>(props: Props<T>) => {
     return () => {
       unlistenResized.then((fn) => fn());
       editorRef.current?.dispose();
-      editorRef.current = null;
+      editorRef.current = undefined;
     };
   }, [editorResize]);
 
   return (
-    <Dialog open={open} onClose={handleClose} maxWidth="xl" fullWidth>
+    <Dialog open={open} onClose={onClose} maxWidth="xl" fullWidth>
       <DialogTitle>{resolvedTitle}</DialogTitle>
 
       <DialogContent