From 27ab6d1b5cec5f27f997073a5f16fde0c0006b77 Mon Sep 17 00:00:00 2001
From: Xia Wanxu <93875470+YsielX@users.noreply.github.com>
Date: Fri, 30 May 2025 10:17:18 +0800
Subject: [PATCH] fix: apply DNS hosts only if useHosts is true (#742)

Co-authored-by: 2045gemini <2045gemini@gmail.com>
---
 src/renderer/src/pages/dns.tsx | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/src/renderer/src/pages/dns.tsx b/src/renderer/src/pages/dns.tsx
index a0fc0e5..43e14a3 100644
--- a/src/renderer/src/pages/dns.tsx
+++ b/src/renderer/src/pages/dns.tsx
@@ -142,9 +142,6 @@ const DNS: React.FC = () => {
             className="app-nodrag"
             color="primary"
             onPress={() => {
-              const hostsObject = Object.fromEntries(
-                values.hosts.map(({ domain, value }) => [domain, value])
-              )
               const dnsConfig = {
                 ipv6: values.ipv6,
                 'fake-ip-range': values.fakeIPRange,
@@ -165,10 +162,13 @@ const DNS: React.FC = () => {
                   values.nameserverPolicy.map(({ domain, value }) => [domain, value])
                 )
               }
-              onSave({
-                dns: dnsConfig,
-                hosts: hostsObject
-              })
+              const result = { dns: dnsConfig }
+              if (values.useHosts) {
+                result['hosts'] = Object.fromEntries(
+                  values.hosts.map(({ domain, value }) => [domain, value])
+                )
+              }
+              onSave(result)
             }}
           >
             {t('common.save')}