From 8f2e956fd01f700520ad02c310d92d93806dd379 Mon Sep 17 00:00:00 2001
From: xmk23333 <xmk23333@gmail.com>
Date: Mon, 8 Dec 2025 19:58:57 +0800
Subject: [PATCH] perf: optimize connection and log components with memoization
 and state management

---
 .../components/connections/connection-item.tsx    | 15 ++++-----------
 src/renderer/src/components/logs/log-item.tsx     |  4 ++--
 src/renderer/src/pages/connections.tsx            | 14 +++++++++++---
 3 files changed, 17 insertions(+), 16 deletions(-)

diff --git a/src/renderer/src/components/connections/connection-item.tsx b/src/renderer/src/components/connections/connection-item.tsx
index 5b37994..49bdbd9 100644
--- a/src/renderer/src/components/connections/connection-item.tsx
+++ b/src/renderer/src/components/connections/connection-item.tsx
@@ -1,26 +1,19 @@
 import { Button, Card, CardFooter, CardHeader, Chip } from '@heroui/react'
 import { calcTraffic } from '@renderer/utils/calc'
 import dayjs from '@renderer/utils/dayjs'
-import React, { useEffect } from 'react'
+import React from 'react'
 import { CgClose, CgTrash } from 'react-icons/cg'
 
 interface Props {
   index: number
   info: IMihomoConnectionDetail
-  selected: IMihomoConnectionDetail | undefined
   setSelected: React.Dispatch<React.SetStateAction<IMihomoConnectionDetail | undefined>>
   setIsDetailModalOpen: React.Dispatch<React.SetStateAction<boolean>>
   close: (id: string) => void
 }
 
 const ConnectionItem: React.FC<Props> = (props) => {
-  const { index, info, close, selected, setSelected, setIsDetailModalOpen } = props
-
-  useEffect(() => {
-    if (selected?.id === info.id) {
-      setSelected(info)
-    }
-  }, [info])
+  const { index, info, close, setSelected, setIsDetailModalOpen } = props
 
   return (
     <div className={`px-2 pb-2 ${index === 0 ? 'pt-2' : ''}`}>
@@ -37,7 +30,7 @@ const ConnectionItem: React.FC<Props> = (props) => {
             <div className="w-full pr-12">
               <CardHeader className="pb-0 gap-1">
                 <Chip
-                  color={`${info.isActive ? 'primary' : 'danger'}`}
+                  color={info.isActive ? 'primary' : 'danger'}
                   size="sm"
                   radius="sm"
                   variant="dot"
@@ -84,7 +77,7 @@ const ConnectionItem: React.FC<Props> = (props) => {
           </div>
         </Card>
         <Button
-          color={`${info.isActive ? 'warning' : 'danger'}`}
+          color={info.isActive ? 'warning' : 'danger'}
           variant="light"
           isIconOnly
           className="absolute right-2 top-1/2 -translate-y-1/2"
diff --git a/src/renderer/src/components/logs/log-item.tsx b/src/renderer/src/components/logs/log-item.tsx
index 5df9135..8a74974 100644
--- a/src/renderer/src/components/logs/log-item.tsx
+++ b/src/renderer/src/components/logs/log-item.tsx
@@ -14,7 +14,7 @@ const LogItem: React.FC<IMihomoLogInfo & { index: number }> = (props) => {
       <Card>
         <CardHeader className="pb-0 pt-1">
           <div className={`mr-2 text-lg font-bold text-${colorMap[type]}`}>
-            {props.type.toUpperCase()}
+            {type.toUpperCase()}
           </div>
           <small className="text-foreground-500">{time}</small>
         </CardHeader>
@@ -24,4 +24,4 @@ const LogItem: React.FC<IMihomoLogInfo & { index: number }> = (props) => {
   )
 }
 
-export default LogItem
+export default React.memo(LogItem)
diff --git a/src/renderer/src/pages/connections.tsx b/src/renderer/src/pages/connections.tsx
index f75f780..de2345a 100644
--- a/src/renderer/src/pages/connections.tsx
+++ b/src/renderer/src/pages/connections.tsx
@@ -55,6 +55,15 @@ const Connections: React.FC = () => {
     allConnectionsRef.current = allConnections
   }, [activeConnections, allConnections])
 
+  const selectedConnection = useMemo(() => {
+    if (!selected) return undefined
+    return (
+      activeConnections.find((c) => c.id === selected.id) ||
+      closedConnections.find((c) => c.id === selected.id) ||
+      selected
+    )
+  }, [selected, activeConnections, closedConnections])
+
   const handleColumnWidthChange = useCallback(async (widths: Record<string, number>) => {
     await patchAppConfig({ connectionTableColumnWidths: widths })
   }, [patchAppConfig])
@@ -246,8 +255,8 @@ const Connections: React.FC = () => {
         </div>
       }
     >
-      {isDetailModalOpen && selected && (
-        <ConnectionDetailModal onClose={() => setIsDetailModalOpen(false)} connection={selected} />
+      {isDetailModalOpen && selectedConnection && (
+        <ConnectionDetailModal onClose={() => setIsDetailModalOpen(false)} connection={selectedConnection} />
       )}
       <div className="overflow-x-auto sticky top-0 z-40">
         <div className="flex p-2 gap-2">
@@ -403,7 +412,6 @@ const Connections: React.FC = () => {
               <ConnectionItem
                 setSelected={setSelected}
                 setIsDetailModalOpen={setIsDetailModalOpen}
-                selected={selected}
                 close={closeConnection}
                 index={i}
                 key={connection.id}