From d68b2686f7e62aa447a7c53155293371d015c33a Mon Sep 17 00:00:00 2001
From: pompurin404 <pompurin404@mihomo.party>
Date: Mon, 5 Aug 2024 15:41:04 +0800
Subject: [PATCH] optimize rule page performance

---
 .../src/components/rules/rule-item.tsx        |  2 +-
 src/renderer/src/pages/rules.tsx              | 19 ++++++++-----------
 2 files changed, 9 insertions(+), 12 deletions(-)

diff --git a/src/renderer/src/components/rules/rule-item.tsx b/src/renderer/src/components/rules/rule-item.tsx
index a4dbbd8..b09eff8 100644
--- a/src/renderer/src/components/rules/rule-item.tsx
+++ b/src/renderer/src/components/rules/rule-item.tsx
@@ -4,7 +4,7 @@ import React from 'react'
 const RuleItem: React.FC<IMihomoRulesDetail> = (props) => {
   const { type, payload, proxy } = props
   return (
-    <Card className="m-2">
+    <Card className="mb-2 mx-2">
       <CardBody className="flex justify-between">
         <div className="flex justify-between">
           <div className="select-none">{type}</div>
diff --git a/src/renderer/src/pages/rules.tsx b/src/renderer/src/pages/rules.tsx
index 9e9f371..c65cc20 100644
--- a/src/renderer/src/pages/rules.tsx
+++ b/src/renderer/src/pages/rules.tsx
@@ -1,5 +1,6 @@
 import BasePage from '@renderer/components/base/base-page'
 import RuleItem from '@renderer/components/rules/rule-item'
+import { Virtuoso } from 'react-virtuoso'
 import { useMemo, useState } from 'react'
 import { Input } from '@nextui-org/react'
 import useSWR from 'swr'
@@ -31,17 +32,13 @@ const Rules: React.FC = () => {
           onValueChange={setFilter}
         />
       </div>
-      {filteredRules.map((rule, index) => {
-        return (
-          <RuleItem
-            key={rule.payload + index}
-            type={rule.type}
-            payload={rule.payload}
-            proxy={rule.proxy}
-            size={rule.size}
-          />
-        )
-      })}
+      <Virtuoso
+        style={{ height: 'calc(100vh - 100px)' }}
+        data={filteredRules}
+        itemContent={(_, rule) => (
+          <RuleItem type={rule.type} payload={rule.payload} proxy={rule.proxy} size={rule.size} />
+        )}
+      />
     </BasePage>
   )
 }