From fcb323a17ab298fbf835a50e0b33d5b1a17a35e5 Mon Sep 17 00:00:00 2001
From: ForestL <45709305+ForestL18@users.noreply.github.com>
Date: Thu, 10 Apr 2025 19:53:03 +0800
Subject: [PATCH] Errors occurred when reset firewall since no specified
 firewall rules existed (#650)

---
 src/main/sys/misc.ts | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/src/main/sys/misc.ts b/src/main/sys/misc.ts
index b2b3099..e53695b 100644
--- a/src/main/sys/misc.ts
+++ b/src/main/sys/misc.ts
@@ -45,9 +45,12 @@ export async function openUWPTool(): Promise<void> {
 export async function setupFirewall(): Promise<void> {
   const execPromise = promisify(exec)
   const removeCommand = `
-  Remove-NetFirewallRule -DisplayName "mihomo" -ErrorAction SilentlyContinue
-  Remove-NetFirewallRule -DisplayName "mihomo-alpha" -ErrorAction SilentlyContinue
-  Remove-NetFirewallRule -DisplayName "Mihomo Party" -ErrorAction SilentlyContinue
+  $rules = @("mihomo", "mihomo-alpha", "Mihomo Party")
+  foreach ($rule in $rules) {
+    if (Get-NetFirewallRule -DisplayName $rule -ErrorAction SilentlyContinue) {
+      Remove-NetFirewallRule -DisplayName $rule -ErrorAction SilentlyContinue
+    }
+  }
   `
   const createCommand = `
   New-NetFirewallRule -DisplayName "mihomo" -Direction Inbound -Action Allow -Program "${mihomoCorePath('mihomo')}" -Enabled True -Profile Any -ErrorAction SilentlyContinue